[stable11] popovermenu backport #3285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
requested review from
MorrisJobke,
LukasReschke,
jancborchardt and
ChristophWurst
|
@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @butonic and @ChristophWurst to be potential reviewers. |
|
Aaaaand wrong branch -_- |
You could change this nowadays. Just click the edit button on the very to and change it 😉 https://github.com/blog/2224-change-the-base-branch-of-a-pull-request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of the corrected popovermenu.
Main ref: #3024 #3118 #3035
Additional ref: nextcloud/contacts#101
@nextcloud/designers