New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CappedMemoryCache to OCP #33064
Conversation
c857fa5
to
62681dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More return type hints. Ok to have the concrete implementation in the public namespace in this case.
/** | ||
* @since 25.0.0 | ||
*/ | ||
public function remove($key) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public function remove($key) { | |
public function remove($key): bool { |
* @inheritdoc | ||
* @since 25.0.0 | ||
*/ | ||
public function clear($prefix = '') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public function clear($prefix = '') { | |
public function clear($prefix = ''): bool { |
* @return T[] | ||
* @since 25.0.0 | ||
*/ | ||
public function getData() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public function getData() { | |
public function getData(): array { |
} | ||
|
||
|
||
private function garbageCollect() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private function garbageCollect() { | |
private function garbageCollect(): void { |
62681dd
to
f905059
Compare
This is an helpful helper that should be used in more place than just server and this is already the case with groupfodlers, deck, user_oidc and more using it, so let's make it public Signed-off-by: Carl Schwan <carl@carlschwan.eu>
f905059
to
d5c23db
Compare
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public
how to port your app