-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reading blob data as resource #33129
Conversation
/backport to stable24 |
/backport to stable23 |
/backport to stable22 |
@szaimen If you can try this patch |
Can we get a test added? |
fdab572
to
be520d7
Compare
There you go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually meant a real test reading stuff from the database, but fine by me for now
Where would I create such a functional test? Still in |
Yes, tests/lib/AppFramework/DB/EntityTest.php |
Linter is unhappy |
be520d7
to
89c543f
Compare
Made it happy |
Possible performance regression detected Show Output
|
/compile amend / |
89c543f
to
6f65b50
Compare
Why the compile amend? :( |
PostgreSQL returns data as resource when using IQueryBuilder::PARAM_LOB (which is used for QBMapper). Previously we just converted this resource using settype, which produced things like "Resource id #14" instead of the actual resource data. Now we read the stream correctly if the returned data is a resource See context at #22472 Fixes #22439 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
6f65b50
to
1d30fb7
Compare
It was just the wrong command, I guess he wanted to rebase because that is what github complained about. |
yeah, sorry, was rushing through review requests |
PostgreSQL returns data as resource when using
IQueryBuilder::PARAM_LOB
(which is used for QBMapper).Previously we just converted this resource using
settype
, which produced things like"Resource id #14"
instead of the actual resource data.Now we read the stream correctly if the returned data is a resource
See context at #22472
Fixes #22439