Remake Twitter handle saving with Vue and modularize account property components

[Pytal]

Remake Twitter handle saving with Vue for accessibility purposes alongside preparations for allowing simple replacement of other account property sections with Vue

Incorporates improvements to accessibility from the https://github.com/nextcloud/nextcloud-vue library over the legacy PHP implementation

Deprecation

The lookupServerUploadEnabled block

server/apps/settings/templates/settings/personal/personal.info.php

Lines 208 to 235 in 16b06dd

	<?php if ($_['lookupServerUploadEnabled']) { ?>
	<div class="verify <?php if ($_['twitter'] === '' || $_['twitterScope'] !== 'public') {
	p('hidden');
	} ?>">
	<img id="verify-twitter" title="<?php p($_['twitterMessage']); ?>" data-status="<?php p($_['twitterVerification']) ?>" src="
	<?php
	switch ($_['twitterVerification']) {
	case \OC\Accounts\AccountManager::VERIFICATION_IN_PROGRESS:
	p(image_path('core', 'actions/verifying.svg'));
	break;
	case \OC\Accounts\AccountManager::VERIFIED:
	p(image_path('core', 'actions/verified.svg'));
	break;
	default:
	p(image_path('core', 'actions/verify.svg'));
	}
	?>" <?php if ($_['twitterVerification'] === \OC\Accounts\AccountManager::VERIFICATION_IN_PROGRESS || $_['twitterVerification'] === \OC\Accounts\AccountManager::NOT_VERIFIED) {
	print_unescaped(' class="verify-action"');
	} ?>>
	<div class="verification-dialog popovermenu bubble menu">
	<div class="verification-dialog-content">
	<p class="explainVerification"></p>
	<p class="verificationCode"></p>
	<p><?php p($l->t('It can take up to 24 hours before the account is displayed as verified.')); ?></p>
	</div>
	</div>
	</div>
	<?php } ?>

is deprecated and therefore not brought over as it is only displayed under the condition that your Twitter handle is set and the scope is public which is never the case as the public scope was deprecated in 21.0.1

server/lib/public/Accounts/IAccountManager.php

Lines 86 to 91 in 16b06dd

	/**
	* Contact details visible on trusted federated servers and in the public lookup server.
	*
	* @deprecated 21.0.1
	*/
	public const VISIBILITY_PUBLIC = 'public';

Requires

• Consolidate account property getters #33206

[Pytal]

Keeping as draft pending merge of

• Consolidate account property getters #33206

[artonge]

Nice cleanup :)

[Pytal]

Rebased and review-ready

[PVince81]

@Pytal this PR seems to contain a lot more changes than just the Twitter handle, in case it's not a mistake, please adjust the PR title and description

[Pytal]

@Pytal this PR seems to contain a lot more changes than just the Twitter handle, in case it's not a mistake, please adjust the PR title and description

Title updated, description already adjusted and commits already split between modularization and Twitter section

[PVince81]

@Pytal rebase needed and also a second review

[PVince81]

👍