Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add guests and comments to VEVENT #33337

Closed
wants to merge 1 commit into from

Conversation

miaulalala
Copy link
Contributor

Fixes #23927

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala added bug 2. developing Work in progress feature: caldav Related to CalDAV internals labels Jul 25, 2022
@miaulalala miaulalala self-assigned this Jul 25, 2022
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 19 potential problems in the proposed changes. Check the Files changed tab for more details.

@miaulalala
Copy link
Contributor Author

We possibly only need to add the GUEST propety as COMMENT is an RFC defined field and should ideally be supported by the scheduling plugin (i. e. fix it upstream).

@miaulalala
Copy link
Contributor Author

miaulalala commented Aug 8, 2022

Relevant quote from the RFC:

3.8.1.4.  Comment

   Property Name:  COMMENT

   Purpose:  This property specifies non-processing information intended
      to provide a comment to the calendar user.

   Value Type:  TEXT

   Property Parameters:  IANA, non-standard, alternate text
      representation, and language property parameters can be specified
      on this property.

   Conformance:  This property can be specified multiple times in
      "VEVENT", "VTODO", "VJOURNAL", and "VFREEBUSY" calendar components
      as well as in the "STANDARD" and "DAYLIGHT" sub-components.

   Description:  This property is used to specify a comment to the
      calendar user.

   Format Definition:  This property is defined by the following
      notation:

       comment    = "COMMENT" commparam ":" text CRLF

       commparam  = *(
                  ;
                  ; The following are OPTIONAL,
                  ; but MUST NOT occur more than once.
                  ;
                  (";" altrepparam) / (";" languageparam) /
                  ;
                  ; The following is OPTIONAL,
                  ; and MAY occur more than once.
                  ;
                  (";" other-param)
                  ;
                  )

   Example:  The following is an example of this property:

       COMMENT:The meeting really needs to include both ourselves
         and the customer. We can't hold this meeting without them.
         As a matter of fact\, the venue for the meeting ought to be at
         their site. - - John

@miaulalala
Copy link
Contributor Author

Won't fix for now :/

@miaulalala miaulalala closed this Dec 13, 2022
@skjnldsv skjnldsv deleted the enhancement/save-comments-and-guests branch March 14, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug feature: caldav Related to CalDAV internals
Projects
Development

Successfully merging this pull request may close these issues.

Calendar invitation response (guests and comment) not processed
1 participant