Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back TokenCleanupJob to invalidate old temporary tokens #33375

Merged
merged 1 commit into from Aug 25, 2022
Merged

Add back TokenCleanupJob to invalidate old temporary tokens #33375

merged 1 commit into from Aug 25, 2022

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Jul 27, 2022 •
edited

The DefaultTokenCleanupJob removed in #30016 was doing this job previously as it was injecting IProvider, which matched either DefaultToken or PublicKeyToken.

@tcitworld tcitworld added this to the Nextcloud 25 milestone Jul 27, 2022
@tcitworld tcitworld requested review from nickvergessen and a team July 27, 2022 08:54
@tcitworld tcitworld added this to In progress in Thomas things to do via automation Jul 27, 2022
@tcitworld tcitworld requested review from blizzz, skjnldsv and come-nc and removed request for a team July 27, 2022 08:54
@tcitworld tcitworld marked this pull request as ready for review July 27, 2022 08:54
Thomas things to do automation moved this from In progress to Reviewer approved Jul 28, 2022
@Gomez
Copy link
Member

Gomez commented Aug 10, 2022

Please backport to Nextcloud 24, see this comment: https://help.nextcloud.com/t/disconnect-all-sessions-revoking-access-for-all-apps-of-a-user/37955/9

@tcitworld
Copy link
Member Author

/backport stable24

@tcitworld
Copy link
Member Author

/backport to stable24

@Gomez Gomez mentioned this pull request Aug 12, 2022
Closed
@skjnldsv skjnldsv mentioned this pull request Aug 12, 2022
Merged
@skjnldsv skjnldsv added the high label Aug 15, 2022
@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
Merged
@blizzz blizzz mentioned this pull request Aug 24, 2022
Merged
@tcitworld
Add back TokenCleanupJob to invalidate old temporary tokens
3ce1996 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@nickvergessen nickvergessen merged commit 7379313 into master Aug 25, 2022
Thomas things to do automation moved this from Reviewer approved to Done Aug 25, 2022
@nickvergessen nickvergessen deleted the add-back-token-cleanup-job branch August 25, 2022 12:00
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 25, 2022
Merged
@blizzz blizzz mentioned this pull request Aug 30, 2022
Merged
@Ezwen Ezwen mentioned this pull request Sep 9, 2022
Closed
5 tasks
@da-h da-h mentioned this pull request Sep 15, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@come-nc come-nc come-nc approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: authentication high
Projects
No open projects
Thomas things to do
  
Done
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tcitworld @Gomez @nickvergessen @come-nc @skjnldsv