Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in apps/ subdirectory #33393

Closed
wants to merge 1 commit into from
Closed

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Jul 28, 2022

Found via codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/

Signed-off-by: luz paz luzpaz@github.com

@luzpaz luzpaz requested a review from CarlSchwan as a code owner July 28, 2022 11:12
@CarlSchwan CarlSchwan requested review from a team, blizzz and come-nc and removed request for a team August 2, 2022 20:05
@CarlSchwan CarlSchwan assigned CarlSchwan and unassigned CarlSchwan Aug 2, 2022
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Aug 2, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Aug 2, 2022
@come-nc
Copy link
Contributor

come-nc commented Aug 4, 2022

@luzpaz Can you rebase please?

Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 4, 2022

@come-nc, indeed, rebased.

@come-nc
Copy link
Contributor

come-nc commented Aug 4, 2022

@CarlSchwan It needs a compile-amend I think, but I suppose the bot cannot do that on an external repo? Do you know the manual command required to fix it?

This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
@come-nc
Copy link
Contributor

come-nc commented Sep 1, 2022

@luzpaz Can you run npm ci && npm run build and commit the result ?

If not I can import your branch in a local branch and do it.

@luzpaz
Copy link
Contributor Author

luzpaz commented Sep 1, 2022

I'd rather not run npm 🤣

@come-nc
Copy link
Contributor

come-nc commented Sep 5, 2022

I'd rather not run npm rofl

I’ll take it from here then.

@come-nc
Copy link
Contributor

come-nc commented Sep 5, 2022

Superseeded by #33895

@come-nc come-nc closed this Sep 5, 2022
@come-nc
Copy link
Contributor

come-nc commented Sep 6, 2022

@luzpaz Merged, thanks a lot.

@luzpaz luzpaz deleted the fix/apps-typos branch September 6, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants