Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remake profile picture saving with Vue #33409

Merged
merged 1 commit into from Sep 2, 2022
Merged

Remake profile picture saving with Vue #33409

merged 1 commit into from Sep 2, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jul 30, 2022 •
edited

Remake profile picture saving with Vue for accessibility purposes

Legacy code is removed

  • OC.Settings.updateAvatar is dropped and is an API break but low impact as it is unused
  • Drop deprecated @nextcloud/jcrop dependency

Screenshots

Before After
image image
image image

@Pytal Pytal added this to the Nextcloud 25 milestone Jul 30, 2022
@Pytal Pytal self-assigned this Jul 30, 2022
@Pytal Pytal mentioned this pull request Jul 30, 2022
Closed
11 tasks
@Pytal Pytal force-pushed the enh/27869/avatar branch 3 times, most recently from 46bde58 to 5d650ec Compare August 5, 2022 03:28
@Pytal Pytal force-pushed the enh/27869/avatar branch 2 times, most recently from cedfb32 to 8449ce9 Compare August 6, 2022 06:30
@Pytal Pytal force-pushed the enh/27869/avatar branch 3 times, most recently from 8769877 to 623d961 Compare August 9, 2022 05:13
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 9, 2022
@Pytal Pytal force-pushed the enh/27869/avatar branch 4 times, most recently from d9484f7 to c230dc6 Compare August 10, 2022 04:52
This was referenced Aug 12, 2022
Merged
Merged
@blizzz blizzz mentioned this pull request Aug 24, 2022
Merged
@Pytal Pytal requested a review from CarlSchwan as a code owner August 27, 2022 00:30
@Pytal Pytal requested review from a team, PVince81, artonge and skjnldsv and removed request for a team August 27, 2022 00:31
@skjnldsv
Copy link
Member

The cropper part was put inline in the page to be inline edited like other fields but we can put it back in a modal like before if desired @jancborchardt @nimishavijay?

Not sure we gain that much to be in a modal? Maybe just a little more focus? I think it's fine both ways, so if it's technically easier inline, so be it.
But since this is design let's still wait for the design team confirmation :)

@blizzz blizzz mentioned this pull request Aug 30, 2022
Merged
@Pytal
Copy link
Member Author

Pytal commented Sep 1, 2022

Rebased

Not sure we gain that much to be in a modal? Maybe just a little more focus? I think it's fine both ways, so if it's technically easier inline, so be it.

Not necessarily technically easier just that editing stuff inline in the same place that it's displayed seems more intuitive, other than that don't have a strong leaning either way

@skjnldsv
Copy link
Member

skjnldsv commented Sep 1, 2022

Integration is failing
https://drone.nextcloud.com/nextcloud/server/22585/22/3

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 1, 2022
@Pytal Pytal force-pushed the enh/27869/avatar branch 2 times, most recently from 206d366 to c54504c Compare September 1, 2022 17:21
@Pytal
Copy link
Member Author

Pytal commented Sep 1, 2022 •
edited

Rebased with fixed integration tests

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 1, 2022
@Pytal
Remake profile picture saving with Vue
f44d258 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal merged commit 8d2532c into master Sep 2, 2022
@Pytal Pytal deleted the enh/27869/avatar branch September 2, 2022 04:01
@Pytal
Copy link
Member Author

Pytal commented Sep 2, 2022

If there are any further changes we should make @jancborchardt @nimishavijay just ping here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement feature: accessibility feature: settings
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pytal @skjnldsv @CarlSchwan