Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow disabling object store write check #33458

Merged
merged 2 commits into from
Oct 26, 2022
Merged

allow disabling object store write check #33458

merged 2 commits into from
Oct 26, 2022

Conversation

icewind1991
Copy link
Member

In clustered setups replication delay means that trying to read the object directly after writing it can fail.

This allows disabling the check by setting 'validateWrites' => false under the object store arguments in config.php

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 4, 2022
@icewind1991 icewind1991 added this to the Nextcloud 25 milestone Aug 4, 2022
@icewind1991 icewind1991 requested review from a team, juliushaertl, skjnldsv and CarlSchwan and removed request for a team August 4, 2022 11:12
PVince81
PVince81 approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

PVince81 commented Aug 4, 2022

so disabling it by default might cause problems in some scenarios ?

This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
@PVince81
Copy link
Member

/rebase

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 16, 2022
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz
Copy link
Member

blizzz commented Oct 1, 2022

/rebase

@skjnldsv
Copy link
Member

/rebase

@icewind1991 @skjnldsv
allow disabling object store write check
a5036a9 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @skjnldsv
test disabling write check
3357c8e 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@skjnldsv skjnldsv merged commit 5e71875 into master Oct 26, 2022
@skjnldsv skjnldsv deleted the object-store-validate-write branch October 26, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@icewind1991 @PVince81 @blizzz @skjnldsv @juliushaertl