Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "First first run wizzard" #33556

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Revert "First first run wizzard" #33556

merged 3 commits into from
Aug 16, 2022

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 16, 2022 •
edited
Loading

This reverts commit ba3f533 and 13ca01e

This just required the firstrunwizard to adapt to the theming css usage
See nextcloud/firstrunwizard#731

Closes #33539

@skjnldsv skjnldsv added this to the Nextcloud 25 milestone Aug 16, 2022
@skjnldsv skjnldsv requested review from CarlSchwan and a team August 16, 2022 06:55
@skjnldsv skjnldsv self-assigned this Aug 16, 2022
@skjnldsv skjnldsv requested review from PVince81, artonge and Pytal and removed request for a team August 16, 2022 06:55
This was referenced Aug 16, 2022
Merged
Closed
PVince81
PVince81 approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

nickvergessen
nickvergessen approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the weird scaling, but now the background is always blue and no longer influenced by theming. But it's fine by me.

@skjnldsv
Automatically enable plain background if primary colour is set
5f3229e 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit 3e2ab35 into master Aug 16, 2022
@skjnldsv skjnldsv deleted the fix/theming branch August 16, 2022 08:12
@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@PVince81 PVince81 PVince81 approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews feature: theming regression
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skjnldsv @nickvergessen @PVince81