Use LazyUser when creating the user folder #33578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
icewind1991
reviewed
Aug 17, 2022
Merged
nickvergessen
force-pushed
the
bugfix/noid/use-a-lazy-user-when-creating-the-root-folder
branch
from
6d529ce
to
35d7b4e
Compare
CarlSchwan
approved these changes
Aug 18, 2022
juliushaertl
approved these changes
Aug 19, 2022
|
psalm seems unhappy |
nickvergessen
commented
Aug 24, 2022
| @@ -362,7 +363,7 @@ public function getName() { | |||
| * @throws NotPermittedException | |||
| */ | |||
| public function getUserFolder($userId) { | |||
| $userObject = $this->userManager->get($userId); | |||
| $userObject = new LazyUser($userId, $this->userManager); | |||
|
|
|||
| if (is_null($userObject)) { | |||
There was a problem hiding this comment.
Can someone confirm it's save to remove this full block?
CarlSchwan
reviewed
Aug 24, 2022
| @@ -362,7 +363,7 @@ public function getName() { | |||
| * @throws NotPermittedException | |||
| */ | |||
| public function getUserFolder($userId) { | |||
| $userObject = $this->userManager->get($userId); | |||
| $userObject = new LazyUser($userId, $this->userManager); | |||
|
|
|||
| if (is_null($userObject)) { | |||
There was a problem hiding this comment.
Suggested change
| if (is_null($userObject)) { | |
| if (is_null($userObject->getDisplayName())) { |
Merged
4 tasks
Merged
Merged
Merged
Merged
Merged
|
/rebase |
Signed-off-by: Joas Schilling <coding@schilljs.com>
nextcloud-command
force-pushed
the
bugfix/noid/use-a-lazy-user-when-creating-the-root-folder
branch
from
35d7b4e
to
6a2f2a1
Compare
|
Closing for now as we still see the error in our log from time to time which would then be unreachable |
nickvergessen
deleted the
bugfix/noid/use-a-lazy-user-when-creating-the-root-folder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meme channel query count: