New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new vue components in login form #33781
Conversation
master now has the vue components bump :) |
- Improve accessibility - Simply code Signed-off-by: Carl Schwan <carl@carlschwan.eu>
37b8615
to
c12c5ce
Compare
c12c5ce
to
292bd8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good design wise!
Maybe this is irrelevant to this PR but 2 primary buttons close to each other is generally avoided, instead the Login with Keycloak
button can have secondary button styling.
292bd8d
to
bbd0d42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
bbd0d42
to
1351ad1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just 2 details, possibly separate issues from this:
-
Wording-wise we want to get away from saying "user" so should be "account name or email" here
-
Not sure if it was introduced with this, but container has more space to the top than to the left
- Move css in scopped vue components - Port to NcNoteCard all the warning messages Signed-off-by: Carl Schwan <carl@carlschwan.eu>
1351ad1
to
43d1aa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! :)
Close #33822
Error handling: