Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create an svg icon sprite for all action icons #3385

Closed
wants to merge 7 commits into from
Closed

create an svg icon sprite for all action icons #3385

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ec1fcae
create an svg icon sprite for all action icons
ChristophWurst Feb 6, 2017
07a738c
fix icons in files app
ChristophWurst Feb 6, 2017
75d82d8
add makefile
ChristophWurst Feb 21, 2017
dab25c5
add spacing around individual svgs
ChristophWurst Feb 21, 2017
d344991
fix delete icon hover state
ChristophWurst Feb 21, 2017
6ab7188
fix header carets
ChristophWurst Feb 21, 2017
8f3e5f7
Do not overwrite icon's min width/height
ChristophWurst Feb 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions core/css/apps.scss
View file
Open in desktop
Expand Up @@ -684,8 +684,6 @@ em {
/* Keep padding to define the width to
assure correct position of a possible text */
margin: 14px 13px 15px 16px;
min-width: 0; /* Overwrite icons*/
min-height: 0;
opacity: 0.7; /* Default button icon override */
Copy link
Member

@skjnldsv skjnldsv Feb 28, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was used to cancel the min height/width applied to the icons. Since we're using padding to define the height, we don't want the 16x16px minimum set on [class^='icon-'], [class*=' icon-']

}
}
Expand Down