Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menuitem border radius #33937

Merged
merged 1 commit into from Sep 8, 2022
Merged

Fix menuitem border radius #33937

merged 1 commit into from Sep 8, 2022

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Sep 7, 2022

Fix part of #33909

@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Sep 7, 2022
@CarlSchwan CarlSchwan added bug 3. to review Waiting for reviews labels Sep 7, 2022
@CarlSchwan CarlSchwan self-assigned this Sep 7, 2022
@CarlSchwan CarlSchwan requested review from a team, skjnldsv, Pytal and szaimen and removed request for a team September 7, 2022 10:35
.htaccess Outdated Show resolved Hide resolved
@szaimen
Copy link
Contributor

szaimen commented Sep 7, 2022

@CarlSchwan does this also fix the misalignment of the carrot?

@CarlSchwan
Copy link
Member Author

@CarlSchwan does this also fix the misalignment of the carrot?

no just fix the content to use rounded border like everywhere else

@blizzz blizzz mentioned this pull request Sep 7, 2022
Fix #33909

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@szaimen
Copy link
Contributor

szaimen commented Sep 8, 2022

@CarlSchwan does this also fix the misalignment of the carrot?

Can we fix this directly here or shall I do it later? (which would be the double effort imo)

@CarlSchwan
Copy link
Member Author

@CarlSchwan does this also fix the misalignment of the carrot?

Can we fix this directly here or shall I do it later? (which would be the double effort imo)

later

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me then

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 8, 2022
@CarlSchwan CarlSchwan merged commit 58706dd into master Sep 8, 2022
@CarlSchwan CarlSchwan deleted the fix/menuitem-radius branch September 8, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants