Allow to specify allowed groups to share instead of excluded groups

[cdammanintopix]

In my use case, I use Nextcloud to share files with a lot of people that are members of separate groups.
I do not want those people to be able to share files between them, nor to share files with me.
However, I want to allow sharing from my team to those groups.

The feature I need is then to be able to specify allowed groups to share, instead of excluded groups.
Hence, I can create a group with my team, allow it to share, and do not allow this feature to any other groups (without having to list all of them).

Suggested UI:

Relates to #3387

[CarlSchwan]

Code looks good, I'm just unsure if the UI is good enough.

@jancborchardt This is the new UX

• Exclude groups from sharing / allow only groups to share
  [ list-of-groups ]
  • Allow only instead of exclude

I wondering if the title of the group selector should be updated when the checkbox is updated

[cdammanintopix]

This is how it looks with the new UI:

Let me know if I should change it.

Also, should I update the translation files?

[CarlSchwan]

No need to update the translation files, this is done automatically by scripts

[cdammanintopix]

Just added testing 🙂

[jancborchardt]

Hm good question. Sounds like it should be 3 radio options and an input:

Limit sharing based on groups

• Allow sharing for everyone (default)
• Exclude some groups from sharing
• Limit sharing to some groups

And then an input field below the option which is chosen. @nimishavijay?

[nimishavijay]

Agreed with the UX, suggestion on the wording:

Allow sharing for

• everyone (default)
• only some groups
• everyone except some groups

And when an option is selected the input field appears below that option like @jancborchardt mentioned

[jancborchardt]

Sounds good @nimishavijay! Would just switch around option 2 and 3 in the order, so it's sorted by permissiveness.

[cdammanintopix]

New UI:

[cdammanintopix]

Hello @skjnldsv I rebased and fixed the conflicts.
Should I worry about this test No DB unit tests (PHP 8.1) failing?

[cdammanintopix]

Hello @skjnldsv I finally managed to reproduce the issue in the No DB unit tests (PHP 8.1) locally and fixed it.
I rebased and fixed the conflicts. Could you start the tests? All should pass now 🙂 (except Cypress of course)

[cdammanintopix]

Seems like all tests passed (except Cypress that fails on forks), could you merge this then, so that it is included in the next beta? 🙂

[skjnldsv]

Aaaand we have conflicts again 🙈
Sorry @cdammanintopix lots of merges lately, this is frustrating, we're aware of the issue 🥲

EDIT: rebased

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22