Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some constants and functions which have been long deprecated #34329

Merged
merged 2 commits into from
Oct 1, 2022
Merged

Remove some constants and functions which have been long deprecated #34329

merged 2 commits into from
Oct 1, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Sep 29, 2022

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

@come-nc come-nc added the 3. to review Waiting for reviews label Sep 29, 2022
@come-nc come-nc added this to the Nextcloud 26 milestone Sep 29, 2022
@come-nc come-nc requested review from CarlSchwan and a team September 29, 2022 13:16
@come-nc come-nc self-assigned this Sep 29, 2022
@come-nc come-nc requested review from PVince81, ArtificialOwl and tcitworld and removed request for a team September 29, 2022 13:16
@tcitworld
Copy link
Member 

There was 1 failure:

1) Test\ContactsManagerTest::testAddressBookEnumeration
Mock_IAddressBook_f99ebb1e Object (...) does not match expected type "string".

/drone/src/tests/lib/ContactsManagerTest.php:238

@come-nc
Copy link
Contributor Author

come-nc commented Sep 30, 2022

/rebase

@come-nc
Remove some constants and functions which have been long deprecated
5347fb0 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix ContactsManagerTest test
4123eee 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@nextcloud-command nextcloud-command force-pushed the fix/cleanup-long-time-deprecated-stuff branch from b3fd62d to 4123eee Compare September 30, 2022 13:20
@come-nc come-nc merged commit a4c2aee into master Oct 1, 2022
@come-nc come-nc deleted the fix/cleanup-long-time-deprecated-stuff branch October 1, 2022 15:55
@nickvergessen
Copy link
Member

Please document in #34692

@nickvergessen nickvergessen added the pending documentation This pull request needs an associated documentation update label Jan 26, 2023
@come-nc come-nc mentioned this pull request Jan 30, 2023
Closed
@DaphneMuller
Copy link

hello @come-nc ,
Thank you for your work on this pull request! This ticket seems to have the tag 'missing documentation', is there any chance you could clarify what documentation is missing? Is this for admins or for app developers?

@nickvergessen
Copy link
Member

#34692 (comment)

@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@tcitworld tcitworld tcitworld approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@PVince81 PVince81 Awaiting requested review from PVince81

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@come-nc @tcitworld @nickvergessen @DaphneMuller @rullzer