Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Avoid double ldap_unbind in Wizard.php #34577

Merged
merged 2 commits into from Nov 3, 2022
Merged

[stable25] Avoid double ldap_unbind in Wizard.php #34577

merged 2 commits into from Nov 3, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Oct 13, 2022

Manual backport of #34523

@come-nc come-nc added the 3. to review Waiting for reviews label Oct 13, 2022
@come-nc come-nc added this to the Nextcloud 25 milestone Oct 13, 2022
@come-nc come-nc self-assigned this Oct 13, 2022
@come-nc come-nc changed the base branch from master to stable25 October 13, 2022 13:01
@come-nc
Copy link
Contributor Author

come-nc commented Oct 13, 2022

Hum started as PR on master instead of stable25 by mistake, changed but it still failed DCO because of that it seems. Also sorry for all the PR request it was done by the code owner system when on the wrong target.

@come-nc come-nc mentioned this pull request Oct 13, 2022
Merged
2 tasks
@blizzz blizzz mentioned this pull request Oct 14, 2022
Merged
1 task
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 25.0.1 Oct 14, 2022
@blizzz blizzz mentioned this pull request Oct 17, 2022
Merged
@skjnldsv skjnldsv mentioned this pull request Oct 27, 2022
Merged
@skjnldsv
Copy link
Member

Moved to 25.0.2

miaulalala
miaulalala approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

ChristophWurst
ChristophWurst approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nextcloud/server/pull/34577/files?w=1 looks good

@come-nc
Copy link
Contributor Author

come-nc commented Nov 3, 2022

/rebase

@come-nc
Fix code style with codesniffer
29be674 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Avoid double ldap_unbind in Wizard.php
0715524 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Copy link
Contributor Author

come-nc commented Nov 3, 2022

CI failure unrelated

@come-nc come-nc merged commit ac06307 into stable25 Nov 3, 2022
@come-nc come-nc deleted the backport/34523/stable25 branch November 3, 2022 13:08
@come-nc
Copy link
Contributor Author

come-nc commented Nov 3, 2022

/backport to stable24

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 3, 2022
Merged
@blizzz blizzz mentioned this pull request Nov 21, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala miaulalala approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@PVince81 PVince81 Awaiting requested review from PVince81

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 25.0.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@come-nc @skjnldsv @ChristophWurst @miaulalala @blizzz