Remove unneeded checks if it runs on a Windows machine #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the setup check is still there
|
The unit tests are not happy |
MorrisJobke
added
2. developing
nickvergessen
added
3. to review
| * @dataProvider providesInvalidCharsPosix | ||
| * @expectedException \OCP\Files\InvalidCharacterInPathException | ||
| */ | ||
| public function testPathVerificationInvalidCharsPosix($fileName) { | ||
| $storage = new Local(['datadir' => '']); | ||
|
|
||
| $fileName = " 123{$fileName}456 "; | ||
| self::invokePrivate($storage, 'verifyWindowsPath', [$fileName]); | ||
| self::invokePrivate($storage, 'verifyPosixPath', [$fileName]); |
|
Fixed the one test, 👍 for not my part |
|
LGTM |
This was referenced Sep 5, 2021
This was referenced Jan 12, 2022
This was referenced Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to review with whitespace ignored ;) Makes it easier.
cc @rullzer @LukasReschke @nickvergessen @schiessle