Move iMIP to its own interface #34893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
added
bug
3. to review
tcitworld
reviewed
Oct 31, 2022
ChristophWurst
changed the title
ChristophWurst
added
the
pending documentation
|
Should the IManager's methods also be extracted? Same issue here, all implementations of IManager now need to support iMIP. |
IManager is a consumed/injected service. The implementation is done by the server. This is fine. The breaking change only occurs when you add methods to interfaces that are implemented by apps. |
miaulalala
force-pushed
the
fix/move-imip-to-separate-interface
branch
2 times, most recently
from
4590e18
to
f166d4b
Compare
ChristophWurst
approved these changes
Oct 31, 2022
|
Documentation PR here: nextcloud/documentation#9269 |
ChristophWurst
approved these changes
Oct 31, 2022
ChristophWurst
approved these changes
Oct 31, 2022
tcitworld
approved these changes
Oct 31, 2022
and clean up the code a bit. Added: - author Removed: - unused imports Changed: - moved iMIP handling to new interface - pointed code to new implementation Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/move-imip-to-separate-interface
branch
from
e5405d0
to
aebcc31
Compare
|
Drone failure unrelated |
|
Drone failure was related, the dumped autoloader needs an update ;) |
|
PR to fix in #34954 |
miaulalala
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and clean up the code a bit.
The old implementation forced every writable calendar to support iMIP.
Added:
Removed:
Changed:
Documentation: nextcloud/documentation#9269