Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of login headline #35014

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Fix rendering of login headline #35014

merged 1 commit into from
Nov 15, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Nov 8, 2022

Fix #34990

Affects the HTML entities:
& - &
&lt; - <
&gt; - >
&quot; - "
&#39; - '

Backport to 25 only which introduced the headline #34039

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug 3. to review Waiting for reviews labels Nov 8, 2022
@Pytal Pytal added this to the Nextcloud 25.0.2 milestone Nov 8, 2022
@Pytal Pytal self-assigned this Nov 8, 2022
@Pytal
Copy link
Member Author

Pytal commented Nov 8, 2022

/backport to stable25

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didnt test

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if someone put <a href="http://evil-link.com">Nextcloud</a> as their product name? 😛

@szaimen
Copy link
Contributor

szaimen commented Nov 8, 2022

What if someone put <a href="http://evil-link.com">Nextcloud</a> as their product name? 😛

Great idea, I'll do that XD

@szaimen
Copy link
Contributor

szaimen commented Nov 8, 2022

But more serious: @skjnldsv can you approve?

@Pytal
Copy link
Member Author

Pytal commented Nov 8, 2022

What if someone put <a href="http://evil-link.com">Nextcloud</a> as their product name? 😛

Tested and is stripped by

return strip_tags($this->config->getAppValue('theming', 'name', $this->name));

@szaimen szaimen requested review from skjnldsv, a team and PVince81 and removed request for a team November 8, 2022 17:46
@PVince81
Copy link
Member

@skjnldsv do the last changes address your concern ?

@skjnldsv skjnldsv merged commit baf74f0 into master Nov 15, 2022
@skjnldsv skjnldsv deleted the fix/login-headline branch November 15, 2022 08:29
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Name in Theme: tick/quote is incorrectly escaped to HTML code
4 participants