Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mention bubbles not rendered in comment editor #35053

Closed
wants to merge 1 commit into from
Closed

Fix mention bubbles not rendered in comment editor #35053

wants to merge 1 commit into from

Commits on Nov 11, 2022

  1. Fix mention bubbles not rendered in comment editor 

    The NcRichContenteditable requires the "userData" property to be given
to render the mention bubbles. Otherwise after selecting a candidate
mention just "@" followed by the user id is shown in plain text.

To solve that now the data of the candidate mentions is cached whenever
the autocomplete list is shown, and reset once a comment has been sent.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
    @danxuliu @nextcloud-command
    danxuliu authored and nextcloud-command committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    fedc7f4 View commit details
    Browse the repository at this point in the history