Cleanup psalm issues in DB/ContactsManager and Console #35539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
ArtificialOwl,
juliushaertl,
skjnldsv and
come-nc
and removed request for
a team
come-nc
approved these changes
Dec 1, 2022
| $this->ensureMigrationsAreLoaded(); | ||
|
|
||
| $versions = $this->getAvailableVersions(); | ||
| array_unshift($versions, 0); | ||
| array_unshift($versions, '0'); | ||
| /** @var int $offset */ |
There was a problem hiding this comment.
Why this @var? Doesn’t that contradict the comparison with false below?
CarlSchwan
force-pushed
the
cleanup/carl/application-contactsmanager
branch
from
3afb0e5
to
0104e16
Compare
juliushaertl
approved these changes
Dec 2, 2022
|
are test failure related? |
|
/rebase |
szaimen
added
4. to release
nextcloud-command
force-pushed
the
cleanup/carl/application-contactsmanager
branch
from
0104e16
to
9394e2d
Compare
|
phpunit failures... |
szaimen
added
2. developing
Merged
Merged
Merged
|
conflicts :/ |
come-nc
changed the title
come-nc
force-pushed
the
cleanup/carl/application-contactsmanager
branch
from
9394e2d
to
c2a250a
Compare
|
Rebased on master but tests are failing, not clear why. Something in the changes is breaking DB somehow. |
Merged
come-nc
force-pushed
the
cleanup/carl/application-contactsmanager
branch
from
c2a250a
to
f7b7c95
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
cleanup/carl/application-contactsmanager
branch
from
4578072
to
637cafc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.