Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app config for default template path #35759

Merged
merged 1 commit into from Jan 25, 2023

Conversation

tcitworld
Copy link
Member

Checklist

@tcitworld tcitworld added this to the Nextcloud 26 milestone Dec 13, 2022
@tcitworld tcitworld requested review from juliushaertl and a team December 13, 2022 17:33
@tcitworld tcitworld added this to In progress in Thomas things to do via automation Dec 13, 2022
@tcitworld tcitworld self-assigned this Dec 13, 2022
@tcitworld tcitworld requested review from PVince81 and blizzz and removed request for a team December 13, 2022 17:33
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a new configuration options ? If so, this will need to be added to the documentation. :)

@tcitworld
Copy link
Member Author

I used an app config instead of a system config value as this can be sensitive (could be a bad idea to use a path mounted on external storage for instance) and I don't think we document those. But otherwise I don't have any specific opinion on this.

@juliushaertl
Copy link
Member

App config seems fine, but documentation would still be good. Maybe at https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/default_files_configuration.html

@juliushaertl juliushaertl added the pending documentation This pull request needs an associated documentation update label Jan 12, 2023
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thomas things to do automation moved this from In progress to Reviewer approved Jan 16, 2023
@PVince81
Copy link
Member

/rebase

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 16, 2023
@nextcloud-command nextcloud-command force-pushed the add-app-config-for-default-template-path branch from 004d59d to bff2dfb Compare January 16, 2023 13:12
@tcitworld
Copy link
Member Author

Docs are in nextcloud/documentation#9569

@juliushaertl
Copy link
Member

/rebase

@juliushaertl
Copy link
Member

Failures seem unrelated.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@nextcloud-command nextcloud-command force-pushed the add-app-config-for-default-template-path branch from bff2dfb to 00d9d49 Compare January 24, 2023 09:39
@juliushaertl juliushaertl merged commit a249c63 into master Jan 25, 2023
Thomas things to do automation moved this from Reviewer approved to Done Jan 25, 2023
@juliushaertl juliushaertl deleted the add-app-config-for-default-template-path branch January 25, 2023 11:35
@juliushaertl juliushaertl removed the pending documentation This pull request needs an associated documentation update label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: templates
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants