New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add app config for default template path #35759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a new configuration options ? If so, this will need to be added to the documentation. :)
I used an app config instead of a system config value as this can be sensitive (could be a bad idea to use a path mounted on external storage for instance) and I don't think we document those. But otherwise I don't have any specific opinion on this. |
App config seems fine, but documentation would still be good. Maybe at https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/default_files_configuration.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/rebase |
004d59d
to
bff2dfb
Compare
Docs are in nextcloud/documentation#9569 |
/rebase |
Failures seem unrelated. |
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
bff2dfb
to
00d9d49
Compare
Checklist