Specify the parameters of FederatedFileSharing controllers #36214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested review from
ArtificialOwl and
icewind1991
and removed request for
a team
|
Shouldn't the parameters also be documented in the comment with explanations? |
nickvergessen
force-pushed
the
techdebt/noid/define-parameters-of-federated-file-sharing
branch
from
c7ca1b4
to
36e5a37
Compare
Did that, just repushed because I forgot it on the first method
Not sure I'm fully qualified to provide this. |
|
Explanations could be copied from https://github.com/cs3org/OCM-API/blob/develop/spec.yaml |
|
It also doesn't matter too much right now, I'd just copy them later |
provokateurin
requested changes
Jan 18, 2023
|
Closing for now as it's the wrong endpoint |
|
This is relevant now. I reopened because I would have just created the same PR again. |
provokateurin
force-pushed
the
techdebt/noid/define-parameters-of-federated-file-sharing
branch
from
36e5a37
to
7819975
Compare
provokateurin
approved these changes
Jun 14, 2023
ChristophWurst
approved these changes
Jun 14, 2023
Signed-off-by: Joas Schilling <coding@schilljs.com>
provokateurin
force-pushed
the
techdebt/noid/define-parameters-of-federated-file-sharing
branch
from
7819975
to
bf4c5bd
Compare
provokateurin
deleted the
techdebt/noid/define-parameters-of-federated-file-sharing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to get closer to OpenAPI all controllers should be up to the state of art how to defining the parameters so they are documented.
Checklist