Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create <h3> headings for profile page. Replace <label> which have… #37211

Merged
merged 1 commit into from Mar 24, 2023
Merged

Create <h3> headings for profile page. Replace <label> which have… #37211

merged 1 commit into from Mar 24, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Mar 14, 2023 •
edited

Create <h3> headings for profile page. Replace <label> which have no connected <input> with <h3> heading

Summary

No visual changes.

Screenshot from 2023-03-14 14-10-26

Screenshot from 2023-03-14 14-11-19

Screenshot from 2023-03-14 14-11-55

Checklist

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Mar 14, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Mar 14, 2023
@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable25

@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable26

@nickvergessen nickvergessen removed their request for review March 14, 2023 14:59
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36912-create-headings-instead-of-uneeded-labels branch from bee426f to 49d42e7 Compare March 16, 2023 13:24
ChristophWurst
ChristophWurst approved these changes Mar 16, 2023
View reviewed changes
apps/settings/css/settings.scss Outdated Show resolved Hide resolved
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36912-create-headings-instead-of-uneeded-labels branch from adb0874 to ddfc100 Compare March 23, 2023 16:04
@JuliaKirschenheuter
Create <h3> headings for profile page. Replace <label> which have…
85feae6 
… no conncted `<input>` with `<h3>` heading

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36912-create-headings-instead-of-uneeded-labels branch from ddfc100 to 85feae6 Compare March 24, 2023 07:49
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 24, 2023
@juliushaertl
Copy link
Member

Failures unrelated

@juliushaertl juliushaertl merged commit ca1f07b into master Mar 24, 2023
36 checks passed
@juliushaertl juliushaertl deleted the fix/36912-create-headings-instead-of-uneeded-labels branch March 24, 2023 13:56
This was referenced Mar 24, 2023
Merged
Merged
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Mar 24, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@Pytal Pytal Pytal approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BITV] 9.1.3.1a/6.1 - All label elements of form elements were mistakenly marked as headings. (1)
4 participants
@JuliaKirschenheuter @juliushaertl @ChristophWurst @Pytal