Fix : Hides hidden files and folder in modal (beginning with a dot)

[Jerome-Herbinet]

Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com

Summary

Fixes the mentioned problem in this modal (IMO this is a problem) :

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[artonge]

Works, but a bit of a hack, no?
What would a solution in js look like?

[Jerome-Herbinet]

Works, but a bit of a hack, no? What would a solution in js look like?

@artonge, I have no skill on JS, so I don't know what could be the solution.

[artonge]

I dug a little, and looks like a condition already exist, but it is wrong in my opinion.

server/core/src/OC/dialogs.js

Lines 1174 to 1179 in 9db3305

	const showHiddenInput = document.getElementById('showHiddenFiles')
	const showHidden = showHiddenInput === null || showHiddenInput.value === "1"
	if (!showHidden) {
	files = files.filter(function(file) {
	return !file.name.startsWith('.')
	})

The code is searching for #showHiddenFiles, but no component with this id is created for the settings page. It is only created for files. The code then default to showing hidden files, which is unexpected, it should be the opposite.

Replacing the code by the following works. @Jerome-Herbinet can you handle that? I don't think I can push to your branch.

		const showHiddenInput = document.getElementById('showHiddenFiles')
		if (showHiddenInput?.value !== "1") {
			files = files.filter(function (file) {
				return !file.name.startsWith('.')
			})
		}

Commit: 1fa58be

[Jerome-Herbinet]

I dug a little, and looks like a condition already exist, but it is wrong in my opinion.

server/core/src/OC/dialogs.js

Lines 1174 to 1179 in 9db3305

	const showHiddenInput = document.getElementById('showHiddenFiles')
	const showHidden = showHiddenInput === null || showHiddenInput.value === "1"
	if (!showHidden) {
	files = files.filter(function(file) {
	return !file.name.startsWith('.')
	})

The code is searching for #showHiddenFiles, but no component with this id is created for the settings page. It is only created for files. The code then default to showing hidden files, which is unexpected, it should be the opposite.

Replacing the code by the following works. @Jerome-Herbinet can you handle that? I don't think I can push to your branch.

		const showHiddenInput = document.getElementById('showHiddenFiles')
		if (showHiddenInput?.value !== "1") {
			files = files.filter(function (file) {
				return !file.name.startsWith('.')
			})
		}

Commit: 1fa58be

Done @artonge :-)

[Jerome-Herbinet]

I dug a little, and looks like a condition already exist, but it is wrong in my opinion.

server/core/src/OC/dialogs.js

Lines 1174 to 1179 in 9db3305

	const showHiddenInput = document.getElementById('showHiddenFiles')
	const showHidden = showHiddenInput === null || showHiddenInput.value === "1"
	if (!showHidden) {
	files = files.filter(function(file) {
	return !file.name.startsWith('.')
	})

The code is searching for #showHiddenFiles, but no component with this id is created for the settings page. It is only created for files. The code then default to showing hidden files, which is unexpected, it should be the opposite.
Replacing the code by the following works. @Jerome-Herbinet can you handle that? I don't think I can push to your branch.

		const showHiddenInput = document.getElementById('showHiddenFiles')
		if (showHiddenInput?.value !== "1") {
			files = files.filter(function (file) {
				return !file.name.startsWith('.')
			})
		}

Commit: 1fa58be

Done @artonge :-)

Can you test on your side @artonge ?

[artonge]

Can you remove the original change? It should not be needed anymore

[Jerome-Herbinet]

Can you remove the original change? It should not be needed anymore

Done + npm run sass @artonge

[artonge]

Perfect 👌
CI is complaining about the compiled files, your local node_modules might need an update with npm ci, then compile again.

[Jerome-Herbinet]

Perfect ok_hand CI is complaining about the compiled files, your local node_modules might need an update with npm ci, then compile again.

Done