Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Always create user directory when transfering files to new users #37625

Merged
merged 1 commit into from Apr 11, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Apr 6, 2023

#30953 was originally there to fix this however with the partial file system setup in 24 we no longer setup the full file system when requesting the user root. This means that the call for getUserFolder does not create the folder but returns a LazyRootFolder instead. However since further handling of transfer ownership does not go through the Nodes API the actual RootFolder handling is never triggered. Explicitly calling for a full FS setup fixes this.

Steps to reproduce:

  • Create a new user that has never logged in
  • call occ files:transfer-ownership admin newuser

Fixes #35111

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Copy link
Member Author

/backport to stable26

@juliushaertl
Copy link
Member Author

/backport to stable25

@juliushaertl
Copy link
Member Author

/backport to stable24

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@juliushaertl
Copy link
Member Author

Failure unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: occ transfer ownership of files will fail if the new created user has never been logged in
3 participants