Refactors Command/Encryption/Enable.php to improve code readability. #37665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity. Improves the readability of the "execute" method by using early returns and reducing the code indentation. Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
szaimen
requested review from
a team,
ArtificialOwl,
icewind1991 and
blizzz
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| $defaultModule = $this->config->getAppValue('core', 'default_encryption_module', null); |
Check notice
Code scanning / Psalm
NullArgument Note
| } | ||
| $defaultModule = $this->config->getAppValue('core', 'default_encryption_module', null); | ||
| if ($defaultModule === null) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction Note
blizzz
approved these changes
Apr 11, 2023
icewind1991
approved these changes
Apr 21, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
|
CI failure is unrealted. So merge or wait for the branch-off? |
szaimen
added
4. to release
Merged
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Behind branch-off, this is for 28. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves the readability of the "execute" method by using early returns and reducing the code indentation.