Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable26] Trap focus in dialogs #37911

Merged
merged 2 commits into from Apr 25, 2023
Merged

[stable26] Trap focus in dialogs #37911

merged 2 commits into from Apr 25, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Apr 25, 2023 •
edited by Pytal

  • ⚠️ This backport had conflicts that were resolved with the 'ours' merge strategy and is likely incomplete

backport of #37780

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 26.0.2 milestone Apr 25, 2023
@Pytal Pytal self-assigned this Apr 25, 2023
@Pytal Pytal added the 3. to review Waiting for reviews label Apr 25, 2023
@Pytal Pytal marked this pull request as ready for review April 25, 2023 00:28
@Pytal Pytal requested a review from hamza221 April 25, 2023 00:29
@Pytal @artonge
Add focus-trap
58773c5 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 87ae9bb)
@Pytal @artonge
Trap focus in dialogs
c02a34f 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 79310bd)
@artonge
Copy link
Contributor

artonge commented Apr 25, 2023

Rebased

@artonge artonge enabled auto-merge April 25, 2023 07:59
@artonge artonge merged commit 7fdc049 into stable26 Apr 25, 2023
37 checks passed
@artonge artonge deleted the backport/37780/stable26 branch April 25, 2023 09:02
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 25, 2023
@blizzz blizzz mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@hamza221 hamza221 Awaiting requested review from hamza221

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Milestone
Nextcloud 26.0.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@artonge @JuliaKirschenheuter @Pytal