chore(404): Extend 404 error message to mention possibly missing permissions #37932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issions Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
changed the title
juliushaertl
approved these changes
Apr 26, 2023
szaimen
approved these changes
Apr 26, 2023
|
CI failure unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We sometimes return a 404 when the user doesn't have permission to view a file, to avoid leaking the information that the file exists. To avoid confusing users, let's add that information to the message.
Checklist