Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update HowToApplyALicense.md #38047

Merged
merged 1 commit into from Feb 23, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented May 3, 2023

Summary

I'd like to improve HowToApplyALicense.md

  1. Update applying to an existing file with a diff
  2. Add different files for different file types (add html-like for .vue)
  3. Add different samples for different types of source:

The current example doesn't work on frontend. It is blocked by @nextcloud/eslint-config. Which inherits eslint-plugin-jsdoc and checks the license by spdx-expression-parse. So all JS files have AGPL-3.0-or-later instead of recommended by this doc GNU AGPL version 3 or any later version.

Checklist

@ShGKme ShGKme added the 3. to review Waiting for reviews label May 3, 2023
contribute/HowToApplyALicense.md Show resolved Hide resolved
@solracsf solracsf added this to the Nextcloud 28 milestone Nov 21, 2023
@blizzz blizzz mentioned this pull request Nov 22, 2023
5 tasks
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 23, 2024
Signed-off-by: Grigorii Shartsev <me@shgk.me>

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@AndyScherzinger AndyScherzinger force-pushed the chore/update-how-to-apply-a-license branch from 9e422ae to 19ec523 Compare February 23, 2024 17:47
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Feb 23, 2024

This comment was marked as resolved.

@skjnldsv skjnldsv merged commit 437b53e into master Feb 23, 2024
97 of 98 checks passed
@skjnldsv skjnldsv deleted the chore/update-how-to-apply-a-license branch February 23, 2024 20:35
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants