New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label to "default quota" multiselect #38075
Add label to "default quota" multiselect #38075
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we take the opportunity to switch to NcSelect?
https://nextcloud-vue-components.netlify.app/#/Components/NcSelect
f29e037
to
0060a85
Compare
I've converted NcMultiselect to NcSelect but have 2 problems:
@Pytal , @susnux could you please check out this state and help me with correction? Thanks a lot! |
Because the |
This works, but is no the reason for the issue. The settings close as soon as you select a quota because the dropdown menu is not rendered within the settings, but the body so the click outside toggle of See comment :) |
Thank you! Absolutely fine! Works |
e005f5b
to
784059f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Have you checked whether the quota is actually changed in the DB? |
I've checked it by reloading a page and by expecting a same value as set before. Should i double check in DB? Which table should i check for it? Thank you! |
10b47b4
to
18ec8a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently adding custom quotas is broken :/
ba3a6a4
to
1daf2b7
Compare
1daf2b7
to
e4f6068
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides that two minor comments everything is fine 😃
e4f6068
to
b79b770
Compare
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
b79b770
to
1c90d7f
Compare
Summary
Correct label for "default quota" multiselect. No visual changes.
Checklist