Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MariaDB 10.11 (LTS) and PHP 8.2 to drone pipeline #38161

Closed
wants to merge 1 commit into from

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented May 9, 2023

Summary

Test against the most modern database and PHP version, that will both be present in next Debian and Ubuntu major versions.

See https://mariadb.org/mariadb-10-11-is-lts/

Checklist

@solracsf solracsf added the 3. to review Waiting for reviews label May 9, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone May 9, 2023
@szaimen szaimen requested review from a team, ArtificialOwl, icewind1991 and Fenn-CS and removed request for a team May 9, 2023 23:13
@solracsf solracsf mentioned this pull request Aug 17, 2023
4 tasks
@nickvergessen
Copy link
Member

We first need to update doctrine, the version we are running was never tested against 10.11, so there could be issues in queries that are just not covered by tests:
https://github.com/doctrine/dbal/blob/3.3.8/.github/workflows/continuous-integration.yml#L262-L297

But I'm working on that in #38556 already

@solracsf
Copy link
Member Author

@nickvergessen FYI, i'm runing MariaDB 10.11 on a (small, 88 users) production instance (v26.0.10) since v26.0.6 without any issues. If this helps.

# occ app:list
Enabled:
  - bookmarks: 13.0.1
  - bruteforcesettings: 2.6.0
  - calendar: 4.4.4
  - cloud_federation_api: 1.9.0
  - contacts: 5.3.2
  - contactsinteraction: 1.7.0
  - dav: 1.25.0
  - deck: 1.9.2
  - drop_account: 2.2.0
  - federatedfilesharing: 1.16.0
  - files: 1.21.1
  - files_automatedtagging: 1.16.1
  - files_pdfviewer: 2.7.0
  - files_rightclick: 1.5.0
  - files_sharing: 1.18.0
  - files_trashbin: 1.16.0
  - forms: 3.3.1
  - impersonate: 1.13.1
  - logreader: 2.11.0
  - lookup_server_connector: 1.14.0
  - notes: 4.8.1
  - notifications: 2.14.0
  - notify_push: 0.6.3
  - oauth2: 1.14.1
  - onlyoffice: 7.9.0
  - password_policy: 1.16.0
  - photos: 2.2.0
  - provisioning_api: 1.16.0
  - quota_warning: 1.17.0
  - registration: 2.2.0
  - related_resources: 1.1.0
  - settings: 1.8.0
  - sharebymail: 1.16.0
  - tasks: 0.15.0
  - theming: 2.1.1
  - twofactor_backupcodes: 1.15.0
  - twofactor_totp: 8.0.0
  - viewer: 1.10.0
  - workflowengine: 2.8.0

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf
Copy link
Member Author

As #38556 is merged are we good to go here?

@nickvergessen
Copy link
Member

It's part of https://github.com/nextcloud/server/pull/41003/files#diff-75f40316acc51e43abf0a9c631008bda05acfbc0c1c6024eba3583066420e5dcR59 and we are removing drone.
So I'm closing this PR here.

Thanks for all the efforts anyway!

@nickvergessen nickvergessen deleted the droneCuttingEdge branch October 26, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants