Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance template picker size and layout depending on aspect ratio #38174

Merged
merged 1 commit into from May 10, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented May 10, 2023

Adapt the template picker modal size to large to take more use of screen when available and adapt the sizing of the previews to be

  • maximum 3 per line for landscape aspect ratio, size has been increased
  • maximum 4 per line for portrait/square aspect ratio

Summary

Before After
Screenshot 2023-05-10 at 12 18 21 Screenshot 2023-05-10 at 12 11 02
Screenshot 2023-05-10 at 12 18 48 Screenshot 2023-05-10 at 12 11 15
Screenshot 2023-05-10 at 12 18 37 Screenshot 2023-05-10 at 12 11 44
Screenshot 2023-05-10 at 12 18 30 Screenshot 2023-05-10 at 12 11 29

Checklist

@juliushaertl juliushaertl added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews labels May 10, 2023
@juliushaertl juliushaertl added this to the Nextcloud 27 milestone May 10, 2023
@juliushaertl
Copy link
Member Author

cc @nickvergessen As i noticed that talk has a similar picker implementation on its own

https://github.com/nextcloud/spreed/blob/master/src/components/NewMessageForm/NewMessageForm.vue#L489

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Fine by me then but didnt test

@szaimen
Copy link
Contributor

szaimen commented May 10, 2023

However the buttons to confirm and cancel being so far apart on the left and right looks kind of strange to me...

@nickvergessen
Copy link
Member

Thanks for the ping, added a talk issue for tracking

@juliushaertl juliushaertl self-assigned this May 10, 2023
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, very good idea @juliushaertl! 👍 as discussed! :)

However the buttons to confirm and cancel being so far apart on the left and right looks kind of strange to me...

@szaimen yeah, although I wouldn’t put them directly next to each other either. Rather we could remove the Cancel button since there is already an X close on the top right. We also don’t have a "Cancel" in the Move/Copy dialog for example.

@szaimen
Copy link
Contributor

szaimen commented May 10, 2023

Rather we could remove the Cancel button since there is already an X close on the top right. We also don’t have a "Cancel" in the Move/Copy dialog for example.

Good point

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Copy link
Member Author

Done:
Screenshot 2023-05-10 at 15 30 52

@szaimen szaimen enabled auto-merge May 10, 2023 14:31
@szaimen szaimen merged commit 928b3b3 into master May 10, 2023
37 checks passed
@szaimen szaimen deleted the enh/template-picker branch May 10, 2023 16:13
@blizzz blizzz mentioned this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants