Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add utility command for object store objects #38226

Merged
merged 1 commit into from Jun 9, 2023
Merged

Conversation

icewind1991
Copy link
Member

Adds some basic utility command for working directly with objects on the object store.

While admins should usually go through the regular file utilities instead of touching the object store directly. In some cases, such as if there is a desync between the object store and filecache, this isn't an option.
If we detect that the admin is trying to touch an object that belongs to an existing file, a warning is shown.

By having an option to do this directly trough occ it removes the requirement for admins to install 3rdparty tools such as s3cmd and the object store configuration can be infered from the nextcloud config.

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label May 12, 2023
@icewind1991 icewind1991 added this to the Nextcloud 28 milestone May 12, 2023
@icewind1991 icewind1991 requested a review from a team May 12, 2023 16:14
apps/files/lib/Command/Object/Get.php Fixed Show fixed Hide fixed
apps/files/lib/Command/Object/Get.php Fixed Show fixed Hide fixed
apps/files/lib/Command/Object/ObjectUtil.php Fixed Show fixed Hide fixed
apps/files/lib/Command/Object/ObjectUtil.php Fixed Show fixed Hide fixed
apps/files/lib/Command/Object/ObjectUtil.php Fixed Show fixed Hide fixed
apps/files/lib/Command/Object/Put.php Fixed Show fixed Hide fixed
@szaimen szaimen removed their request for review May 12, 2023 16:21
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some copy-pasting errors, but fine 👍

apps/files/lib/Command/Object/Get.php Outdated Show resolved Hide resolved
apps/files/lib/Command/Object/Put.php Outdated Show resolved Hide resolved
apps/files/lib/Command/Object/Put.php Outdated Show resolved Hide resolved
apps/files/lib/Command/Object/Get.php Outdated Show resolved Hide resolved
apps/files/lib/Command/Object/Get.php Outdated Show resolved Hide resolved
apps/files/lib/Command/Object/Get.php Outdated Show resolved Hide resolved
apps/files/lib/Command/Object/Get.php Show resolved Hide resolved
apps/files/lib/Command/Object/Get.php Outdated Show resolved Hide resolved
apps/files/lib/Command/Object/ObjectUtil.php Show resolved Hide resolved
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 merged commit 3ef5090 into master Jun 9, 2023
37 of 38 checks passed
@icewind1991 icewind1991 deleted the file-object-utils branch June 9, 2023 18:53
@icewind1991
Copy link
Member Author

/backport to stable27

@icewind1991
Copy link
Member Author

/backport to stable26

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants