Refactors "strpos" calls in lib/private to improve code readability. #38261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fsamapoor
commented
May 15, 2023
fsamapoor
commented
- Code is properly formatted
- Sign-off message is added to all commits
Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>
kesselb
requested review from
a team,
ArtificialOwl,
icewind1991 and
Fenn-CS
and removed request for
a team
icewind1991
approved these changes
May 17, 2023
The latter implies the former. nextcloud#38261 (comment) Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
nextcloud#38261 (comment) Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
szaimen
added
4. to release
This was referenced Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.