38340 fix add group broken #38344
Merged
38340 fix add group broken #38344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenn-CS
force-pushed
the
38340-fix-add-group-broken
branch
3 times, most recently
from
29dd7f6
to
7f4ce58
Compare
Fenn-CS
requested review from
a team,
ArtificialOwl,
icewind1991,
come-nc,
susnux and
artonge
and removed request for
a team
Fenn-CS
force-pushed
the
38340-fix-add-group-broken
branch
from
7f4ce58
to
40cff7b
Compare
artonge
approved these changes
May 17, 2023
|
Sad that linting is not able to warn us on this kind of mistake |
Fenn-CS
force-pushed
the
38340-fix-add-group-broken
branch
from
40cff7b
to
3421ff6
Compare
It could if we would use TS and nextcloud-vue would provide type information 😉 |
susnux
approved these changes
May 17, 2023
|
/backport to stable27 |
|
/compile amend / |
nextcloud-command
force-pushed
the
38340-fix-add-group-broken
branch
from
3421ff6
to
e9e9879
Compare
Fenn-CS
force-pushed
the
38340-fix-add-group-broken
branch
from
e9e9879
to
9c7606d
Compare
|
/compile amend / |
1ee8fba broke the addgroup functionality by not updating the event to reflect the one in https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcAppNavigationNewItem/NcAppNavigationNewItem.vue Resolves : #38340 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
38340-fix-add-group-broken
branch
from
9c7606d
to
ec91547
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1ee8fbaad1eea6544b21059f65efe12a9e601956 broke the addgroup functionality by not updating the event to reflect the one in
https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcAppNavigationNewItem/NcAppNavigationNewItem.vue
Resolves : #38340