Make unsupported browser check asynchronous #38354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulsejet
requested review from
juliushaertl,
a team,
susnux,
Fenn-CS and
szaimen
and removed request for
a team
rullzer
approved these changes
May 19, 2023
susnux
approved these changes
May 19, 2023
|
/rebase |
nextcloud-command
force-pushed
the
pulsejet/patch-ubr
branch
from
8ce156d
to
947c1cc
Compare
|
/compile amend / |
nextcloud-command
force-pushed
the
pulsejet/patch-ubr
branch
from
947c1cc
to
98ddb81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check is very expensive, and will pass almost 100% of the time.
Shaves off at least around 100ms (or more)
Related #36728
Depends on (but not blocked by) #38329 (lazy loading is broken currently in general, see #38329 (comment))