add commands to copy/move files #38366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
skjnldsv,
Pytal,
ArtificialOwl,
come-nc,
artonge,
szaimen,
susnux and
Fenn-CS
as code owners
icewind1991
requested review from
ArtificialOwl,
Fenn-CS and
come-nc
and removed request for
a team
come-nc
reviewed
May 22, 2023
artonge
reviewed
May 22, 2023
icewind1991
force-pushed
the
file-command-copy-move
branch
from
1d9a8b3
to
bbdce42
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| if ($wouldRequireDelete && $targetNode->getInternalPath() === '') { |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
| return 1; | ||
| } | ||
|
|
||
| if ($wouldRequireDelete && !$targetNode->isDeletable()) { |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
come-nc
approved these changes
Jun 5, 2023
artonge
approved these changes
Jun 5, 2023
|
conflicts |
szaimen
added
2. developing
Signed-off-by: Robin Appelman <robin@icewind.nl>
susnux
force-pushed
the
file-command-copy-move
branch
from
bbdce42
to
38640bf
Compare
susnux
added
3. to review
susnux
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #37971
occ files:copy <source> <target>occ files:move <source> <target>