Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialisation of versions in the DB #38469

Merged
merged 2 commits into from May 30, 2023
Merged

Conversation

artonge
Copy link
Contributor

@artonge artonge commented May 25, 2023

Broken after #36690

$userFolder was only set for SharedStorage
Also took the opportunity to fix some psalm warnings.

@artonge artonge self-assigned this May 25, 2023
@artonge artonge added 3. to review Waiting for reviews feature: versions php Pull requests that update Php code bug labels May 25, 2023
@artonge artonge added this to the Nextcloud 28 milestone May 25, 2023
@artonge
Copy link
Contributor Author

artonge commented May 25, 2023

/backport to stable27

@artonge
Copy link
Contributor Author

artonge commented May 25, 2023

/backport to stable26

@artonge
Copy link
Contributor Author

artonge commented May 25, 2023

/backport to stable25

Broken after #36690

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/versions_init branch from 1c6f4f8 to c3475f4 Compare May 25, 2023 21:44
@artonge artonge requested a review from come-nc May 30, 2023 09:32
@artonge artonge requested a review from come-nc May 30, 2023 09:52
@artonge artonge merged commit 3053df7 into master May 30, 2023
37 checks passed
@artonge artonge deleted the artonge/fix/versions_init branch May 30, 2023 11:38
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin/stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug feature: versions php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants