Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contrast for inactive elements of the main navigation #38519

Merged
merged 1 commit into from Jun 6, 2023
Merged

Fix contrast for inactive elements of the main navigation #38519

merged 1 commit into from Jun 6, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented May 30, 2023 •
edited by susnux

Summary

Increase contrast for inactive elements of the main navigation.

Before After
Screenshot from 2023-05-30 16-17-29 Screenshot from 2023-05-30 16-18-46
Screenshot from 2023-05-30 16-18-24 Screenshot from 2023-05-30 16-17-52

Checklist

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label May 30, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this May 30, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone May 30, 2023
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 30, 2023
@Pytal
Copy link
Member

Pytal commented May 31, 2023 

Error: Action failed. Missing package manager lockfile. Expecting one of package-lock.json (npm), pnpm-lock.yaml (pnpm) or yarn.lock (yarn) in working-directory /home/runner/actions-runner/_work/server/server

@artonge
Copy link
Contributor

artonge commented May 31, 2023

/rebase

@artonge
Copy link
Contributor

artonge commented May 31, 2023 •
edited

CI errors are probably due to the new GH runners and can probably be ignored

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36967-increase-contrast-of-inactive-elements branch from d34730f to cc5b024 Compare June 1, 2023 07:17
@susnux susnux force-pushed the fix/36967-increase-contrast-of-inactive-elements branch from cc5b024 to 11bb2b2 Compare June 5, 2023 12:44
@JuliaKirschenheuter @susnux
Fix contrast for inactive elements of the main navigation
1d6121b 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@susnux susnux force-pushed the fix/36967-increase-contrast-of-inactive-elements branch from 11bb2b2 to 1d6121b Compare June 5, 2023 12:47
@susnux susnux enabled auto-merge June 5, 2023 12:50
@susnux susnux merged commit d80277c into master Jun 6, 2023
38 checks passed
@susnux susnux deleted the fix/36967-increase-contrast-of-inactive-elements branch June 6, 2023 08:46
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Aug 21, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@susnux susnux susnux approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

@nimishavijay nimishavijay nimishavijay approved these changes

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 28
7 participants
@JuliaKirschenheuter @Pytal @artonge @jancborchardt @susnux @szaimen @nimishavijay