Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app): Do not clear unused cache key #38524

Merged
merged 1 commit into from Jun 5, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented May 30, 2023

Summary

Drive-by fix while reading some code. I am not able to find any usage of that cache key.

d01cfde added the code.

Checklist

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 28 milestone May 30, 2023
@ChristophWurst ChristophWurst requested a review from a team May 30, 2023 15:50
@ChristophWurst ChristophWurst self-assigned this May 30, 2023
@ChristophWurst ChristophWurst requested review from ArtificialOwl, icewind1991, blizzz and nickvergessen and removed request for a team May 30, 2023 15:50
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 31, 2023
@blizzz blizzz merged commit ffa30ce into master Jun 5, 2023
32 of 37 checks passed
@blizzz blizzz deleted the chore/app/clear-unused-cache-key branch June 5, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: apps management technical debt
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants