Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix app menu flicker #38549

Merged
merged 1 commit into from May 31, 2023
Merged

Fix app menu flicker #38549

merged 1 commit into from May 31, 2023

Conversation

ZetaTom
Copy link
Contributor

@ZetaTom ZetaTom commented May 31, 2023 •
edited by szaimen

Summary

This fixes a small annoyance when hovering over the app menu. Previously hovering just below the app menu bar would lead to the labels flickering.

TODO

Checklist

@szaimen szaimen added bug 3. to review Waiting for reviews labels May 31, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone May 31, 2023
szaimen
szaimen approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this! Works well in my testing! :)

@szaimen szaimen requested review from nickvergessen, juliushaertl, skjnldsv, a team, susnux and Pytal and removed request for a team May 31, 2023 13:02
@szaimen
Copy link
Contributor

szaimen commented May 31, 2023

/backport to stable27

@szaimen
Copy link
Contributor

szaimen commented May 31, 2023

/backport to stable26

@szaimen
Copy link
Contributor

szaimen commented May 31, 2023

/backport to stable25

@ZetaTom
Fix app menu flicker
d17fd19 
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
@ZetaTom
Copy link
Contributor Author

ZetaTom commented May 31, 2023

Apologies; I forgot to sign off my commit.

@szaimen szaimen merged commit 81463ea into nextcloud:master May 31, 2023
37 checks passed
@welcome
Copy link

welcome bot commented May 31, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

This was referenced May 31, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@susnux susnux Awaiting requested review from susnux susnux was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 28
3 participants
@ZetaTom @szaimen @Pytal