Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop \OC_App methods deprecated in Nextcloud 14 #38566

Merged
merged 4 commits into from Jun 1, 2023
Merged

Drop \OC_App methods deprecated in Nextcloud 14 #38566

merged 4 commits into from Jun 1, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented May 31, 2023 •
edited

Summary

The methods were deprecated in Nextcloud 14, released 2018-09-10.

TODO

  • Inline remaining usages
  • Drop the methods

Checklist

@ChristophWurst ChristophWurst added this to the Nextcloud 28 milestone May 31, 2023
@ChristophWurst ChristophWurst mentioned this pull request May 31, 2023
Merged
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label May 31, 2023
nickvergessen
nickvergessen approved these changes Jun 1, 2023
View reviewed changes
lib/private/legacy/OC_App.php Outdated Show resolved Hide resolved
lib/private/legacy/OC_App.php Outdated Show resolved Hide resolved
@ChristophWurst
chore: Drop \OC_App::getAppVersion
cf6e2fa 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
chore: Drop \OC_App::getAppInfo
e76d525 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
chore: Drop \OC_App::getNavigation
167763d 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
chore: Drop \OC_App::getSettingsNavigation
999aec3 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
Copy link
Member Author

CI was green already. Just rebased to squash. This can be merged after the second review.

@rullzer
Copy link
Member

rullzer commented Jun 1, 2023

CI was green already. Just rebased to squash. This can be merged after the second review.

and a happy drone

@nickvergessen nickvergessen merged commit 1a3bb23 into master Jun 1, 2023
36 of 37 checks passed
@nickvergessen nickvergessen deleted the chore/drop-oc-app-methods branch June 1, 2023 14:45
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@susnux susnux Awaiting requested review from susnux

@tcitworld tcitworld Awaiting requested review from tcitworld

@kesselb kesselb Awaiting requested review from kesselb

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees
No one assigned
Labels
3. to review Waiting for reviews technical debt
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChristophWurst @rullzer @nickvergessen