Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove check for suhosin.executor.func.blacklist #38595

Merged
merged 1 commit into from Jun 2, 2023
Merged

chore: remove check for suhosin.executor.func.blacklist #38595

merged 1 commit into from Jun 2, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jun 1, 2023 •
edited

Summary

Suhosin is/was a PHP extension.
The last release was 2015-05-21.
Suhosin does not support PHP 8.

TODO

  • CI

Checklist

@kesselb kesselb self-assigned this Jun 1, 2023
@kesselb kesselb added 3. to review Waiting for reviews technical debt labels Jun 1, 2023
@kesselb kesselb requested review from a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team June 1, 2023 19:23
solracsf
solracsf approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@solracsf solracsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kesselb
chore: remove check for suhosin.executor.func.blacklist
3d3c497 
Suhosin is/was a PHP extension.
The last release was 2015-05-21.
Suhosin does not support PHP 8.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 2, 2023
@blizzz blizzz added this to the Nextcloud 28 milestone Jun 2, 2023
@kesselb kesselb merged commit 2188505 into master Jun 2, 2023
37 checks passed
@kesselb kesselb deleted the remove-suhosin-check branch June 2, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@solracsf solracsf solracsf approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz blizzz was automatically assigned from nextcloud/server-backend

Assignees

@kesselb kesselb

Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kesselb @icewind1991 @solracsf @blizzz