Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(caldav): Cast calendar objects id to int when building index #38648

Merged
merged 1 commit into from Jun 6, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jun 5, 2023

Summary

Fixes

TypeError: Return value of OCA\DAV\BackgroundJob\BuildReminderIndexBackgroundJob::buildIndex() must be of the type int, string returned in /var/www/html/nextcloud/apps/dav/lib/BackgroundJob/BuildReminderIndexBackgroundJob.php:123
Stack trace:
#0 /var/www/html/nextcloud/apps/dav/lib/BackgroundJob/BuildReminderIndexBackgroundJob.php(80): OCA\DAV\BackgroundJob\BuildReminderIndexBackgroundJob->buildIndex()
#1 /var/www/html/nextcloud/lib/public/BackgroundJob/Job.php(78): OCA\DAV\BackgroundJob\BuildReminderIndexBackgroundJob->run()
#2 /var/www/html/nextcloud/lib/public/BackgroundJob/QueuedJob.php(58): OCP\BackgroundJob\Job->start()
#3 /var/www/html/nextcloud/lib/public/BackgroundJob/QueuedJob.php(48): OCP\BackgroundJob\QueuedJob->start()
#4 /var/www/html/nextcloud/cron.php(152): OCP\BackgroundJob\QueuedJob->execute()
#5 {main}

My guess is that the database driver sometimes returns an int, other times it gives a string (sqlite?).

TODO

  • Do

Checklist

@ChristophWurst ChristophWurst added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Jun 5, 2023
@ChristophWurst ChristophWurst added this to the Nextcloud 28 milestone Jun 5, 2023
@ChristophWurst ChristophWurst self-assigned this Jun 5, 2023
@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst
Copy link
Member Author

/backport to stable26

@ChristophWurst
Copy link
Member Author

/backport to stable25

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the fix/caldav/reminder-index-int-id-cast branch from 5107842 to a213650 Compare June 6, 2023 07:45
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 6, 2023
@ChristophWurst ChristophWurst merged commit 4d8c963 into master Jun 6, 2023
37 checks passed
@ChristophWurst ChristophWurst deleted the fix/caldav/reminder-index-int-id-cast branch June 6, 2023 13:33
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin/stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ChristophWurst
Copy link
Member Author

/backport to stable26

@ChristophWurst
Copy link
Member Author

/backport to stable25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: caldav Related to CalDAV internals
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants