fix(SystemTagManager): Use truncated tagName in getTag and updateTag #38667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable27 |
|
/backport to stable26 |
|
/backport to stable25 |
marcelklehr
requested review from
julien-nc
and removed request for
nickvergessen
nickvergessen
approved these changes
Jun 21, 2023
miaulalala
approved these changes
Jun 21, 2023
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
fix/systemtagmanager-gettag-updatetag
branch
from
f9f672c
to
424937f
Compare
|
CI failure seems unrelated. Pls merge |
nickvergessen
approved these changes
Jul 27, 2023
This was referenced Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The tag name column has a length limit. We should always truncate tagName inputs in SystemTagManager for consistency.
Checklist