Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Dependabot configuration to autoupdate GitHub action versions #38737

Merged
merged 1 commit into from Jun 12, 2023

Conversation

kurtmckee
Copy link
Member

  • Resolves: No issue filed

Summary

GitHub workflow logs show that some of the actions are running on Node 12, which is deprecated and will be removed soon. [example from a recent run]

This can be addressed by adding a Dependabot configuration for GitHub action versions. Therefore this PR targets a Dependabot configuration for ongoing updates, rather than updating the action versions as a one-off.

I've added sign-off signatures to my git commits. Please let me know if I overlooked anything that needs to be addressed.

Thanks for your work on NextCloud!

TODO

  • ...

Checklist

Signed-off-by: Kurt McKee <contactme@kurtmckee.org>
@szaimen szaimen requested a review from a team June 12, 2023 07:58
@szaimen szaimen added the 3. to review Waiting for reviews label Jun 12, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone Jun 12, 2023
Copy link
Contributor

@Fenn-CS Fenn-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks great according to official GitHub notes.

One minor change request, can we just leave this as weekly? And leave the default Once-a-week timing for Github (Scheduled on Mondays?)

Consideration: We could also make this monthly, I don't think actions change so fast.

.github/dependabot.yml Show resolved Hide resolved
Copy link
Contributor

@Fenn-CS Fenn-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Jun 12, 2023

We would then wait for CI to get green :)

@kurtmckee
Copy link
Member Author

Thanks, @Fenn-CS! I want CI to go green, too.

It appears the failures are unrelated to this change, however, and that many recent commits to the default git branch have failed for varying reasons. Would it be an option to re-run the failed CI jobs to see if they clear up on a second run?

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Jun 12, 2023

You could rerun, but usually I just wait when I know it's unrelated.

It would magically become green if it can :)

@kurtmckee
Copy link
Member Author

kurtmckee commented Jun 12, 2023

I'm not able to independently autonomously re-run the failed jobs. Is that something you're able to re-run?

@szaimen
Copy link
Contributor

szaimen commented Jun 12, 2023

CI failure unrelated

@szaimen szaimen merged commit 7903b42 into nextcloud:master Jun 12, 2023
35 of 37 checks passed
@welcome
Copy link

welcome bot commented Jun 12, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@kurtmckee kurtmckee deleted the add-dependabot-for-actions branch June 12, 2023 22:10
@skjnldsv
Copy link
Member

@Fenn-CS @susnux I think this generates too much noise for a repo as big as Server.
No one have time to look at all those updates :/

I would prefer to keep the auto-update from the template repository imho, what do you think? Revert?

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Feb 21, 2024

@skjnldsv Not a big deal, so if we are having too many depenabot pr's to review that no one has time to look at, it makes sense to revert.

@kurtmckee
Copy link
Member Author

I just did a double-check of Dependabot's PR submissions and found that Dependabot is responsible for 4% of the PRs submitted to this repo, but those numbers stretch back to 2019, four years before this merged.

@skjnldsv It's fine to revert this change, but I wanted to confirm that you're specifically referring to the GitHub actions that this PR introduced? There are additional levers that could be pulled:

  • The update cadence seems aggressive; it could be tuned to "monthly" instead of "weekly"
  • The updates could be batched, so the project only sees one PR each month, tops

Again, it's fine to revert this change, but I can update the settings if that's helpful.

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Feb 21, 2024

The update cadence seems aggressive; it could be tuned to "monthly" instead of "weekly"

I am also fine with this.

@susnux
Copy link
Contributor

susnux commented Feb 21, 2024

I think this generates too much noise for a repo as big as Server.

The problem here is that we do not use only workflows from the templates. Mostly we use completly different workflows as the templates are for apps but here we have some special cases (all the files_external or object-storage etc).

So I think dependabot does not allow groups and we do not want to use Renovate? Then I would go with:

The update cadence seems aggressive; it could be tuned to "monthly" instead of "weekly"

@kurtmckee
Copy link
Member Author

kurtmckee commented Feb 21, 2024

Dependabot supports batched updates. Here's an example PR from one of my repositories, with all available GitHub actions updates rolled into a single PR.

@skjnldsv
Copy link
Member

The update cadence seems aggressive; it could be tuned to "monthly" instead of "weekly"

good for me too

@skjnldsv
Copy link
Member

#43730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants