align subadmins css class name #38793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
ChristophWurst,
JuliaKirschenheuter,
a team,
susnux,
artonge and
Pytal
and removed request for
a team
Jenandra
force-pushed
the
fix-subadminsgroups-css-name
branch
from
73adc86
to
eb4bddb
Compare
artonge
requested changes
Jun 14, 2023
You're perfectly right, I seem to have missed the spots where the subadmins class is actually used. I've duplicated the css now so both class names work, thanks! |
added 2 commits
June 15, 2023 15:39
…sGroups to fix display issue when users are in many groups Signed-off-by: Silke Suck <silke.suck@adacor.com>
Signed-off-by: Silke Suck <silke.suck@adacor.com>
artonge
force-pushed
the
fix-subadminsgroups-css-name
branch
from
e7ddbd6
to
1442cfb
Compare
JuliaKirschenheuter
approved these changes
Jun 16, 2023
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Thanks @Jenandra ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The actually used class name in apps/settings/src/components/UserList/UserRowSimple.vue is subAdminsGroups. Because of this, css for the subadmins groups column in the user list is missing, causing formatting to break when users are admins of many (10+) groups.
See also: https://help.nextcloud.com/t/ansicht-von-user-mit-vielen-gruppen-ist-unubersichtlich/72149/3