Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable version features again with S3 versioning #38794

Merged
merged 1 commit into from Jun 13, 2023
Merged

Enable version features again with S3 versioning #38794

merged 1 commit into from Jun 13, 2023

Conversation

bensmrs
Copy link
Contributor

@bensmrs bensmrs commented Jun 13, 2023

Summary

After nextcloud/files_versions_s3#28 is merged, we can enable version features with the S3 versioning backend again.

@bensmrs
Enable version features again with S3 versioning
75e0461 
Signed-off-by: Benjamin Somers <bsomers@resel.fr>
@szaimen szaimen requested review from artonge, a team, icewind1991, Fenn-CS and come-nc and removed request for a team June 13, 2023 13:25
@szaimen szaimen added the 3. to review Waiting for reviews label Jun 13, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone Jun 13, 2023
artonge
artonge requested changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is support for deleting and labeling versions was added to files_versions_s3?

@bensmrs
Copy link
Contributor Author

bensmrs commented Jun 13, 2023

Is support for deleting and labeling versions was added to files_versions_s3?

Yes, it has been implemented by nextcloud/files_versions_s3#27

@artonge
Copy link
Contributor

artonge commented Jun 13, 2023

Awesome @bensmrs. Can you fix DCO ?

@bensmrs
Copy link
Contributor Author

bensmrs commented Jun 13, 2023

Hmmm I have several affiliations and the one I signed with is really the one that should appear… Any way for you to force the DCO without me having to switch my main email on GitHub (and switching it back to the current one 😓)?

@joshtrichards
Copy link
Member

@bensmrs You add other email addresses in GH without messing with your primary one:

https://github.com/settings/emails

@bensmrs
Copy link
Contributor Author

bensmrs commented Jun 13, 2023

It’s already the case…
IMG_8771

@artonge artonge merged commit 69f6585 into nextcloud:master Jun 13, 2023
36 of 37 checks passed
@welcome
Copy link

welcome bot commented Jun 13, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@artonge
Copy link
Contributor

artonge commented Jun 13, 2023

Done @bensmrs, thanks a lot for pushing this !! 🎉

@icewind1991
Copy link
Member

/backport to stable27

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 4, 2023
Merged
@artonge artonge mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@artonge artonge artonge approved these changes

@Fenn-CS Fenn-CS Fenn-CS approved these changes

@come-nc come-nc Awaiting requested review from come-nc come-nc was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews backport-request
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bensmrs @artonge @joshtrichards @icewind1991 @Fenn-CS @szaimen